linux-kernel - Re: [PATCH 07/14] ide-cd: clear sense buffer before issuing request sense

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49CB2E20.5030202@kernel.org>
Date:	Thu, 26 Mar 2009 16:26:24 +0900
From:	Tejun Heo <tj@...nel.org>
To:	petkovbb@...il.com, Tejun Heo <tj@...nel.org>, bzolnier@...il.com,
	linux-kernel@...r.kernel.org, axboe@...nel.dk,
	linux-ide@...r.kernel.org
Subject: Re: [PATCH 07/14] ide-cd: clear sense buffer before issuing	request
 sense

Hello,

Borislav Petkov wrote:
> Hmm, not quite. If its info->sense_data, then 18 is not correct. Rather,
> sizeof(struct request_sense) would be more likely the proper length. So,
> actually, it would be more like:
> 
> unsigned sense_len = 18;
> 
> if (sense == NULL) {
> 	sense = &info->sense_data;
> 	sense_len = sizeof(struct request_sense);
> }
> 
> memset(sense, 0, sense_len);

Okay, will update as such.  Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/