linux-kernel - Re: [PATCH] tracing/ftrace: factorize the tracing files creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090327064424.GB5959@nowhere>
Date:	Fri, 27 Mar 2009 07:44:25 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/ftrace: factorize the tracing files creation

On Thu, Mar 26, 2009 at 08:04:43PM -0400, Steven Rostedt wrote:
> 
> 
> On Thu, 26 Mar 2009, Steven Rostedt wrote:
> 
> > 
> > On Fri, 27 Mar 2009, Frederic Weisbecker wrote:
> > 
> > > Impact: cleanup
> > > 
> > > Most of the tracing files creation follow the same pattern:
> > > 
> > > ret = debugfs_create_file(...)
> > > if (!ret)
> > > 	pr_warning("Couldn't create ... entry\n")
> > > 
> > > Unify it!
> > > 
> > 
> > I could have sworn I did this before. I found this patch with the 
> > timestamp dated Feb 8, 2008.  This is even before we came up with the name 
> > "ftrace" and I was still calling it "mcount".
> > 
> > Oh well, it somehow never got out :-(
> > 
> > I'll Ack yours ;-)
> > 
> > 
> > Old patch:
> > 
> > From: Steven Rostedt <srostedt@...hat.com>
> > Subject: clean up trace debugfs error messages
> > 
> > The debugfs creation had a bunch of cut and paste errors
> > in the prints. This patch creates a single function to
> > create the debugfs file and print out the error if it
> > fails.
> > 
> > Signed-off-by: Steven Rostedt <srostedt@...hat.com>
> 
> I always wondered why Ingo never pulled it in. I can not find any record 
> of me emailing it. I've not only searched Google, but it is not in any of 
> my "sent" folders either. I must have been suffering a senior moment, and 
> thought I emailed it when I never did :-/
> 
> -- Steve
> 


Be care, that's not the first time! Remember this old copy_from_user_inatomic() ?

:-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/