linux-kernel - Re: [tip:tracing/kmemtrace] fs.h: uninline simple_transaction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090327092601.GA8234@elte.hu>
Date:	Fri, 27 Mar 2009 10:26:01 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	penberg@...helsinki.fi, eduard.munteanu@...ux360.ro,
	tglx@...utronix.de, adobriyan@...il.com,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:tracing/kmemtrace] fs.h: uninline simple_transaction_set()


* Al Viro <viro@...IV.linux.org.uk> wrote:

> On Wed, Mar 25, 2009 at 04:51:28PM +0000, Ingo Molnar wrote:
> > Commit-ID:  44eea45ca9e25d6dd660d4806ef4c11209609e03
> > Gitweb:     http://git.kernel.org/tip/44eea45ca9e25d6dd660d4806ef4c11209609e03
> > Author:     Ingo Molnar <mingo@...e.hu>
> > AuthorDate: Wed, 25 Mar 2009 16:48:35 +0100
> > Committer:  Ingo Molnar <mingo@...e.hu>
> > CommitDate: Wed, 25 Mar 2009 17:48:14 +0100
> > 
> > fs.h: uninline simple_transaction_set()
> > 
> > Move simple_transaction_set() to the other simple-transaction
> > file helpers in fs/libfs.c.
> > 
> > This removes an implicit asm/page.h PAGE_SIZE dependency from
> > fs.h (asm/page.h is not an exported header so HEADERS_CHECK fils),
> > and also reduces kernel size a bit.
> 
> *shrug*

Thanks for the encouragement - it must be a lot of fun for you to 
work with other people and you seem to be taking great pride in 
seeing improvements to the code you maintain and care about, no 
matter how insignificant they seem in isolation ;-)

> I can live with that.  Which tree do you want that to go through?  
> I'll be pushing VFS queue tonight.

Either way is certainly fine with me, you are the maintainer so it's 
your call. I kept the branch isolated and can adopt.

Note: the patch i sent has some (very minimal) dependencies on a 
previous patchlet [which adds the asm/page.h include to fs.h - that 
dependency was implicit before], it will be all just fine if you 
ignore the fs.h reject when you apply the patch.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/