linux-kernel - Re: netrom: zero length frame filtering in NetRom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090327102823.3c485bfc@lxorguk.ukuu.org.uk>
Date:	Fri, 27 Mar 2009 10:28:23 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	davem@...emloft.net
Subject: Re: netrom: zero length frame filtering in NetRom


> +	/* NetRom empty data frame has no meaning : ignore it */
> +	if (copied == 0) {
> +		goto out;
> +	}
> +

Also broken - and doesn't follow the coding style either 8)

I'm not familiar enough with ROSE to tell if the ROSE one is wrong, but
rose is X.25 LL based (sadly without the X.29 layer) so it seems odd
there too (especially for datagram services)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/