linux-kernel - Re: [GIT PULL] Microblaze initial pack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Mar 2009 11:40:45 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Michal Simek <monstr@...str.eu>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	torvalds@...ux-foundation.org,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	lkml <linux-arch@...r.kernel.org>,
	microblaze-uclinux@...e.uq.edu.au,
	Andrew Morton <akpm@...ux-foundation.org>,
	John Williams <john.williams@...alogix.com>,
	John Linn <John.Linn@...inx.com>,
	Stephen Neuendorffer <stephenn@...inx.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Arnd Bergmann <arnd@...db.de>,
	Peter Korsgaard <jacmet@...site.dk>
Subject: Re: [GIT PULL] Microblaze initial pack


* Ingo Molnar <mingo@...e.hu> wrote:

> I have noticed one relatively big (but easily fixable) commit 
> structure problem in this tree.
> 
> All of the commits have these tags:
> 
>     Reviewed-by: Stephen Neuendorffer <stephen.neuendorffer@...inx.com>
>     Acked-by: John Linn <john.linn@...inx.com>
>     Acked-by: John Williams<john.williams@...alogix.com>

I forgot to mention that in any case _your_ signoff as the submitter 
of this tree should be in all commits as well.

So for example this (sample) chain would be fine:

     Reviewed-by: Stephen Neuendorffer <stephen.neuendorffer@...inx.com>
     Acked-by: John Linn <john.linn@...inx.com>
     Acked-by: John Williams<john.williams@...alogix.com>
     Signed-off-by: Michal Simek <monstr@...str.eu>

It's not enough to be listed as the author in the commit. (In any 
case please see Documentation/SubmittingPatches and the DCO 1.1.)

Also, a minor stylistic detail, please fix this:

     John Williams<john.williams@...alogix.com>

to:

     John Williams <john.williams@...alogix.com>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/