linux-kernel - Re: [PATCH] radio-mr800.c: Missing mutex include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Mar 2009 07:11:43 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Alexey Klimov <klimov.linux@...il.com>
Cc:	Alessio Igor Bogani <abogani@...ware.it>,
	LKML <linux-kernel@...r.kernel.org>, linux-media@...r.kernel.org,
	video4linux-list@...hat.com
Subject: Re: [PATCH] radio-mr800.c: Missing mutex include

On Wed, 18 Mar 2009 00:42:08 +0300
Alexey Klimov <klimov.linux@...il.com> wrote:

> On Tue, 2009-03-17 at 22:00 +0100, Alessio Igor Bogani wrote:
> > radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
> > pulled in indirectly by one of the headers it already includes, the
> > right thing is to include it directly.
> 
> 
> Hello, Alessio
> 
> Patch looks okay for my eyes.
> If it useful it should be applied.
> 
> Thank you!
> 
> Mauro, if patch is okay please apply it.
> If you need my ack - here it is:
> Acked-by: Alexey Klimov <klimov.linux@...il.com>

If the mutex.h were already included by another kernel header, I don't see why
to include it again. If a later patch remove the mutex.h from the header, then
the patch author should take care of this change anyway.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/