linux-kernel - Re: [PATCH] btrfs: fix __ucmpdi2 compile bug on 32 bit builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 28 Mar 2009 01:16:26 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Chris Mason <chris.mason@...cle.com>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] btrfs: fix __ucmpdi2 compile bug on 32 bit builds

Hi Heiko,

On Fri, 27 Mar 2009 13:42:52 +0100 Heiko Carstens <heiko.carstens@...ibm.com> wrote:
>
\> @@ -2884,25 +2884,19 @@ int extent_fiemap(struct inode *inode, s
>  		disko = 0;
>  		flags = 0;
>  
> -		switch (em->block_start) {
> -		case EXTENT_MAP_LAST_BYTE:
> +		if (em->block_start == EXTENT_MAP_LAST_BYTE) {

I might be a good idea to put a comment there about why this isn't a
switch statement so that someone doesn't "clean up" this code in the
future.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped