linux-kernel - Re: [PATCH] btrfs: fix __ucmpdi2 compile bug on 32 bit builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1238164664.27455.8.camel@think.oraclecorp.com>
Date:	Fri, 27 Mar 2009 10:37:44 -0400
From:	Chris Mason <chris.mason@...cle.com>
To:	Kyle McMartin <kyle@...artin.ca>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] btrfs: fix __ucmpdi2 compile bug on 32 bit builds

On Fri, 2009-03-27 at 10:24 -0400, Kyle McMartin wrote:
> On Sat, Mar 28, 2009 at 01:16:26AM +1100, Stephen Rothwell wrote:
> > > -		switch (em->block_start) {
> > > -		case EXTENT_MAP_LAST_BYTE:
> > > +		if (em->block_start == EXTENT_MAP_LAST_BYTE) {
> > 
> > I might be a good idea to put a comment there about why this isn't a
> > switch statement so that someone doesn't "clean up" this code in the
> > future.
> > 
> 
> nrrrgh. Remind me why we can't just add the libgcc helpers?
>
> Unless we plan on growing some more of these, surely we can just reduce
> it to a u32 for the switch...

EXTENT_MAP_LAST_BYTE is something like (u64)-5

This if/else setup is fine, I'll take the patch.

-chris


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/