linux-kernel - Re: [PATCH] Allow relatime to update atime once a day

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <E1LnICd-0001mx-EH@be1.7eggert.dyndns.org>
Date:	Fri, 27 Mar 2009 20:58:55 +0100
From:	Bodo Eggert <7eggert@....de>
To:	Matthew Garrett <mjg@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frans Pop <elendil@...net.nl>, mingo@...e.hu, tytso@....edu,
	jack@...e.cz, alan@...rguk.ukuu.org.uk, arjan@...radead.org,
	a.p.zijlstra@...llo.nl, npiggin@...e.de, jens.axboe@...cle.com,
	drees76@...il.com, jesper@...gh.cc, linux-kernel@...r.kernel.org,
	oleg@...hat.com, roland@...hat.com, willy@...ux.intel.com,
	vaurora@...hat.com
Subject: Re: [PATCH] Allow relatime to update atime once a day

Matthew Garrett <mjg@...hat.com> wrote:

> diff --git a/fs/inode.c b/fs/inode.c
> index 0487ddb..057c92b 100644
> --- a/fs/inode.c

>  now = current_fs_time(inode->i_sb);
> +
> +     if (!relatime_need_update(mnt, inode, now))
> +             goto out;
> +
>  if (timespec_equal(&inode->i_atime, &now))
>  goto out;

Forget what I just said, I should rather read than assume.

But I'm wondering if inlining this once-used function would be a good thing,
since relatime is supposed to be a common option? Otherwise, I'd pull the
flags check out and avoid the function call.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/