linux-kernel - Re: [PULL REQUEST] Quota changes for 2.6.30

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0903271448520.3994@localhost.localdomain>
Date:	Fri, 27 Mar 2009 14:52:11 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jan Kara <jack@...e.cz>
cc:	tytso@....edu, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PULL REQUEST] Quota changes for 2.6.30



On Fri, 27 Mar 2009, Jan Kara wrote:

> On Thu 26-03-09 16:16:47, Linus Torvalds wrote:
> > 
> > 
> > On Thu, 26 Mar 2009, Jan Kara wrote:
> > > 
> > >   could you please pull from
> > > 
> > > git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-quota-2.6.git for_linus
> > 
> > 	"Already up-to-date."
> > 
> > Forgot to actually push it out?
>   Damn, you're right. Should be there now.

It is, but now when I pull I notice that you hadn't used "-M --summary" 
when asking me to pull. You claimed:

	 66 files changed, 4770 insertions(+), 4565 deletions(-)

but in fact it's really:

	 58 files changed, 902 insertions(+), 697 deletions(-)
	 create mode 100644 fs/quota/Kconfig
	 create mode 100644 fs/quota/Makefile
	 rename fs/{ => quota}/dquot.c (85%)
	 rename fs/{ => quota}/quota.c (94%)
	 rename fs/{ => quota}/quota_tree.c (84%)
	 rename fs/{ => quota}/quota_tree.h (100%)
	 rename fs/{ => quota}/quota_v1.c (79%)
	 rename fs/{ => quota}/quota_v2.c (98%)
	 rename fs/{ => quota}/quotaio_v1.h (100%)
	 rename fs/{ => quota}/quotaio_v2.h (100%)

so please do change your pull-request script to add -M (for rename 
detection) and --summary (for that "new, deleted and renamed files" 
summary at the end).

It really does generate a much nicer view of what changed, _especially_ in 
cases like the above when a non-rename patch is mostly movement noise.

Git still defaults to non-rename patches because some people probably 
still use inferior crud that doesn't understand about the extended patch 
semantics of git patches.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/