linux-kernel - Re: [patch 6/9] LTTng instrumentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0903272303580.3397@localhost.localdomain>
Date:	Fri, 27 Mar 2009 23:05:46 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	ltt-dev@...ts.casi.polymtl.ca,
	Frederic Weisbecker <fweisbec@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	Hideo AOKI <haoki@...hat.com>,
	Takashi Nishiie <t-nishiie@...css.fujitsu.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
Subject: Re: [patch 6/9] LTTng instrumentation - timer



On Tue, 24 Mar 2009, Ingo Molnar wrote:

> 
> * Thomas Gleixner <tglx@...utronix.de> wrote:
> 
> > On Tue, 24 Mar 2009, Ingo Molnar wrote:
> > > the init methods are missing from your patch entirely - and the rest 
> > > is partially incomplete as well.
> > > 
> > > Instrumentation of the del_timer() variants is missing. For a 
> > > complete lifetime analysis of timers this cannot be left out.
> > 
> > Look at the debugobjects hooks. They cover the complete timer life 
> > time already.
> > 
> > Piggypacking tracepoints on those would simplify maintenance and 
> > reduce the number of extra lines in the code.
> 
> makes sense. They dont cover itimers nor hrtimers though.

They cover all (hr)timers independent of the call site. And we really
do not need any freaking call site instrumented.

The CPU* timer stuff is a different playground and needs to be
instrumented separate.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/