[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1238196439-16535-57-git-send-email-u.kleine-koenig@pengutronix.de>
Date: Sat, 28 Mar 2009 00:27:18 +0100
From: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
To: linux-kernel@...r.kernel.org
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Philipp Zabel <philipp.zabel@...il.com>,
Ian Molton <spyro@....com>, Richard Purdie <rpurdie@...ys.net>,
Antonino Daplas <adaplas@...il.com>,
Alberto Mardegan <mardy@...rs.sourceforge.net>
Subject: [PATCH 57/58] move w100fb's probe function to .devinit.text
A pointer to w100fb_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Philipp Zabel <philipp.zabel@...il.com>
Cc: Ian Molton <spyro@....com>
Cc: Richard Purdie <rpurdie@...ys.net>
Cc: Antonino Daplas <adaplas@...il.com>
Cc: Alberto Mardegan <mardy@...rs.sourceforge.net>
Cc: Andrew Morton <akpm@...ux-foundation.org>
---
drivers/video/w100fb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/w100fb.c b/drivers/video/w100fb.c
index d0674f1..c966b12 100644
--- a/drivers/video/w100fb.c
+++ b/drivers/video/w100fb.c
@@ -626,7 +626,7 @@ static int w100fb_resume(struct platform_device *dev)
#endif
-int __init w100fb_probe(struct platform_device *pdev)
+int __devinit w100fb_probe(struct platform_device *pdev)
{
int err = -EIO;
struct w100fb_mach_info *inf;
--
1.6.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists