linux-kernel - [PATCH 39/58] move r8a66597_hcd's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1238196439-16535-39-git-send-email-u.kleine-koenig@pengutronix.de>
Date:	Sat, 28 Mar 2009 00:27:00 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	linux-kernel@...r.kernel.org
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Yoshihiro Shimoda <shimoda.yoshihiro@...esas.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Magnus Damm <damm@...l.co.jp>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Paul Mundt <lethal@...ux-sh.org>
Subject: [PATCH 39/58] move r8a66597_hcd's probe function to .devinit.text

A pointer to r8a66597_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Yoshihiro Shimoda <shimoda.yoshihiro@...esas.com>
Cc: Greg Kroah-Hartman <gregkh@...e.de>
Cc: Magnus Damm <damm@...l.co.jp>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Paul Mundt <lethal@...ux-sh.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>
---
 drivers/usb/host/r8a66597-hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c
index f1626e5..3e1216a 100644
--- a/drivers/usb/host/r8a66597-hcd.c
+++ b/drivers/usb/host/r8a66597-hcd.c
@@ -2373,7 +2373,7 @@ static int __init_or_module r8a66597_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static int __init r8a66597_probe(struct platform_device *pdev)
+static int __devinit r8a66597_probe(struct platform_device *pdev)
 {
 #if defined(CONFIG_SUPERH_ON_CHIP_R8A66597) && defined(CONFIG_HAVE_CLK)
 	char clk_name[8];
-- 
1.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/