[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1238196439-16535-20-git-send-email-u.kleine-koenig@pengutronix.de>
Date: Sat, 28 Mar 2009 00:26:41 +0100
From: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
To: linux-kernel@...r.kernel.org
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Akinobu Mita <akinobu.mita@...il.com>,
Richard Purdie <rpurdie@...ux.intel.com>,
Paul Mundt <lethal@...ux-sh.org>,
Kristoffer Ericson <Kristoffer.Ericson@...il.com>,
Andriy Skulysh <askulysh@...il.com>,
Antonino Daplas <adaplas@....net>
Subject: [PATCH 20/58] move hp680-bl's probe function to .devinit.text
A pointer to hp680bl_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Akinobu Mita <akinobu.mita@...il.com>
Cc: Richard Purdie <rpurdie@...ux.intel.com>
Cc: Paul Mundt <lethal@...ux-sh.org>
Cc: Kristoffer Ericson <Kristoffer.Ericson@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Andriy Skulysh <askulysh@...il.com>
Cc: Antonino Daplas <adaplas@....net>
---
drivers/video/backlight/hp680_bl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/hp680_bl.c b/drivers/video/backlight/hp680_bl.c
index 5be55a2..7fb4eef 100644
--- a/drivers/video/backlight/hp680_bl.c
+++ b/drivers/video/backlight/hp680_bl.c
@@ -103,7 +103,7 @@ static struct backlight_ops hp680bl_ops = {
.update_status = hp680bl_set_intensity,
};
-static int __init hp680bl_probe(struct platform_device *pdev)
+static int __devinit hp680bl_probe(struct platform_device *pdev)
{
struct backlight_device *bd;
--
1.6.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists