linux-kernel - Re: [PATCH -tip 1/3] x86, mce: Add mce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090328120825.GB14464@elte.hu>
Date:	Sat, 28 Mar 2009 13:08:25 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH -tip 1/3] x86, mce: Add mce_threshold option for intel
	cmci


* Hidetoshi Seto <seto.hidetoshi@...fujitsu.com> wrote:

> This patch adds a kernel parameter "mce_threshold=n" to enable us
> to change the default threshold for CMCI(Corrected Machine Check
> Interrupt) that recent Intel processor supports.
> 
> And it also supports CMCI disabling by setting mce_threshold=0.
> It would be useful if your hardware does something wrong and/or
> if polling by timer is preferred than the threshold interrupt.
> 
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Cc: Ingo Molnar <mingo@...e.hu>
> ---
>  Documentation/kernel-parameters.txt       |    5 +++
>  arch/x86/include/asm/msr-index.h          |    1 +
>  arch/x86/kernel/cpu/mcheck/mce_intel_64.c |   56 +++++++++++++++++++++++++++--
>  3 files changed, 59 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> index 1d8af36..7a0d117 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -1267,6 +1267,11 @@ and is between 256 and 4096 characters. It is defined in the file
>  
>  	mce=option	[X86-64] See Documentation/x86/x86_64/boot-options.txt
>  
> +	mce_threshold=	[X86-64,intel] Default CMCI threshold
> +			Should be unsigned integer. Setting 0 disables cmci.
> +			Format: <integer>
> +			Default: 1

Makes sense. CMCI is a new CPU feature so having boot controls to 
disable it is generally a good idea - while still having old-style 
MCE support in place.

Applied to tip:x86/mce2, thanks Hidetoshi!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/