linux-kernel - Re: [PATCH 31/58] move omap_hdq's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090328193702.GB5588@pengutronix.de>
Date:	Sat, 28 Mar 2009 20:37:02 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Evgeniy Polyakov <zbr@...emap.net>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Stanley.Miao" <stanley.miao@...driver.com>,
	Madhusudhan Chikkature <madhu.cr@...com>,
	Felipe Balbi <felipe.balbi@...ia.com>
Subject: Re: [PATCH 31/58] move omap_hdq's probe function to .devinit.text

Hi Evgeniy,

On Sat, Mar 28, 2009 at 11:21:49AM +0300, Evgeniy Polyakov wrote:
> On Sat, Mar 28, 2009 at 12:26:52AM +0100, Uwe Kleine-König (u.kleine-koenig@...gutronix.de) wrote:
> > A pointer to omap_hdq_probe is passed to the core via
> > platform_driver_register and so the function must not disappear when the
> > .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> > unbinding and binding a device to the driver via sysfs will result in an
> > oops as does a device being registered late.
> > 
> > An alternative to this patch is using platform_driver_probe instead of
> > platform_driver_register plus removing the pointer to the probe function
> > from the struct platform_driver.
> 
> I wonder if it can be hotplugged, but for the consistency it looks good.
Maybe you cannot really hotplug it, but with CONFIG_HOTPLUG you can
unbind it via sysfs and rebind it afterwards, too.

Can I consider this an Acked-by: you?

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/