[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090328063211.GA1041@pengutronix.de>
Date: Sat, 28 Mar 2009 07:32:11 +0100
From: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
To: David Brownell <david-b@...bell.net>
Cc: linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
"David S. Miller" <davem@...emloft.net>,
Jeff Garzik <jgarzik@...hat.com>,
Paulius Zaleckas <paulius.zaleckas@...tonika.lt>,
Marc Pignat <marc.pignat@...s.ch>,
Andrew Victor <linux@...im.org.za>,
Roel Kluin <12o3l@...cali.nl>
Subject: Re: [PATCH 04/58] move at91_ether's probe function to .devinit.text
Hi David,
On Fri, Mar 27, 2009 at 05:09:37PM -0700, David Brownell wrote:
> On Friday 27 March 2009, Uwe Kleine-König wrote:
> > An alternative to this patch is using platform_driver_probe instead of
> > platform_driver_register plus removing the pointer to the probe function
> > from the struct platform_driver.
>
> IMO that's preferable for this driver. There's no
> point in doing anything other than discarding the
> probe() method after the driver has been set up;
> it'd be doing nothing except wasting memory.
>
> Same thing for ... pretty much all other drivers
> for SoC platform devices.
>
> In this series, you cc'd me on four OMAP drivers
> (mmci-omap, mmci-omap-hs, omap-rng, omap_udc) which
> I *know* that's a completely workable -- and far
> preferable -- solution. There might be others.
So if I convert them to the alternative fix, you volunteer to test these
patches? (Or at least provide your Tested-and-Acked-by:?)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists