linux-kernel - Re: [PATCH 20/58] move hp680-bl's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090328102520.ef5e5faa.kristoffer.ericson@gmail.com>
Date:	Sat, 28 Mar 2009 10:25:20 +0100
From:	Kristoffer Ericson <kristoffer.ericson@...il.com>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Akinobu Mita <akinobu.mita@...il.com>,
	Richard Purdie <rpurdie@...ux.intel.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	Kristoffer Ericson <Kristoffer.Ericson@...il.com>,
	Andriy Skulysh <askulysh@...il.com>,
	Antonino Daplas <adaplas@....net>
Subject: Re: [PATCH 20/58] move hp680-bl's probe function to .devinit.text


Acked-by: Kristoffer Ericson <kristoffer.ericson@...il.com>

On Sat, 28 Mar 2009 00:26:41 +0100
Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:

> A pointer to hp680bl_probe is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
> 
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: Akinobu Mita <akinobu.mita@...il.com>
> Cc: Richard Purdie <rpurdie@...ux.intel.com>
> Cc: Paul Mundt <lethal@...ux-sh.org>
> Cc: Kristoffer Ericson <Kristoffer.Ericson@...il.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Andriy Skulysh <askulysh@...il.com>
> Cc: Antonino Daplas <adaplas@....net>
> ---
>  drivers/video/backlight/hp680_bl.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/backlight/hp680_bl.c b/drivers/video/backlight/hp680_bl.c
> index 5be55a2..7fb4eef 100644
> --- a/drivers/video/backlight/hp680_bl.c
> +++ b/drivers/video/backlight/hp680_bl.c
> @@ -103,7 +103,7 @@ static struct backlight_ops hp680bl_ops = {
>  	.update_status  = hp680bl_set_intensity,
>  };
>  
> -static int __init hp680bl_probe(struct platform_device *pdev)
> +static int __devinit hp680bl_probe(struct platform_device *pdev)
>  {
>  	struct backlight_device *bd;
>  
> -- 
> 1.6.2
> 


-- 
Kristoffer Ericson <kristoffer.ericson@...il.com>

Content of type "application/pgp-signature" skipped