[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090328112035.GA11146@elte.hu>
Date: Sat, 28 Mar 2009 12:20:35 +0100
From: Ingo Molnar <mingo@...e.hu>
To: "Michael K. Johnson" <johnsonm@...th.com>
Cc: jmforbes@...uxtx.org, hpa@...or.com, Jordan_Hargrave@...l.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mark %esi as clobbered in E820 BIOS call
* Michael K. Johnson <johnsonm@...th.com> wrote:
> Justin and Peter, please review this for stable .y trees. Peter,
> please review this for trunk unless you decide to do a more
> extensive workaround for BIOS register clobbering.
>
> Thanks!
>
> $ cat e820-esi-clobber-workaround.patch
> Jordan Hargrave diagnosed a BIOS clobbering %esi in the E820 call.
> That particular BIOS has been fixed, but there is a possibility that
> this is responsible for other occasional reports of early boot
> failure, and it does not hurt to add %esi to the clobbers.
nice fix! Would you mind to update the clobber list to include _all_
registers? I dont see why any of the other registers couldnt be
clobbered by a BIOS, and this is boot-only code so micro-performance
is not an issue.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists