linux-kernel - Re: [PATCH 0/7] Support for GB pages in KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090329124735.GH31080@8bytes.org>
Date:	Sun, 29 Mar 2009 14:47:35 +0200
From:	Joerg Roedel <joro@...tes.org>
To:	Avi Kivity <avi@...hat.com>
Cc:	Marcelo Tosatti <mtosatti@...hat.com>,
	Joerg Roedel <joerg.roedel@....com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] Support for GB pages in KVM

On Sun, Mar 29, 2009 at 03:03:28PM +0300, Avi Kivity wrote:
> Joerg Roedel wrote:
>> On Sat, Mar 28, 2009 at 06:40:08PM -0300, Marcelo Tosatti wrote:
>>   
>>> On Fri, Mar 27, 2009 at 03:31:52PM +0100, Joerg Roedel wrote:
>>>     
>>>> Hi,
>>>>
>>>> this patchset extends the KVM MMU implementation to support 1GB pages as
>>>> supported by AMD family 16 processors. These patches enable support for
>>>> 1 GB pages with Nested Paging. Support for these pages in the shadow
>>>> paging code was also developed but does not run stable yet. The patch
>>>> for shadow-paging support is not included in this series and will be
>>>> sent out seperatly.
>>>>       
>>> Looks generally sane. I'm not sure its even worthwhile to support
>>> GBpages with softmmu, because the chance of finding an area without
>>> shadowed (write protected) pages is much smaller than with 2MB pages.
>>>     
>>
>> Thanks for your review.
>>
>> The idea behind GB pages in softmmu code was to provide GB pages to the
>> guest even if hardware does not support it. This would work better with
>> live migration (Only case where we wouldn't have gbpages then would be
>> vmx with ept enabled).
>>
>>   
>>> Have any numbers to share?
>>>     
>>
>> No numbers I fully trust by now. I measured a 32% improvement in
>> kernbench using nested pages backed with gb pages. I will do some more
>> measurements and share some more solid numbers.
>>
>>   
>
> Compared to 2M pages?  But we're already close to native here.

Yes, thats why I don't trust those numbers. I'll find out what went
wrong and provide more solid numbers.

	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/