linux-kernel - Re: [PATCH 47/58] move sharpsl-pm's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f17812d70903281823n13308520s527766e14af8c8ce@mail.gmail.com>
Date:	Sun, 29 Mar 2009 09:23:46 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dmitry Baryshkov <dbaryshkov@...il.com>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Eric Miao <eric.miao@...vell.com>
Subject: Re: [PATCH 47/58] move sharpsl-pm's probe function to .devinit.text

2009/3/29 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>:
> On Sat, Mar 28, 2009 at 05:32:02PM +0800, Eric Miao wrote:
>> 2009/3/28 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>:
>> > A pointer to sharpsl_pm_probe is passed to the core via
>> > platform_driver_register and so the function must not disappear when the
>> > .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
>> > unbinding and binding a device to the driver via sysfs will result in an
>> > oops as does a device being registered late.
>> >
>> > An alternative to this patch is using platform_driver_probe instead of
>> > platform_driver_register plus removing the pointer to the probe function
>> > from the struct platform_driver.
>> >
>>
>> This one looks OK to me.
> I assume this is an Acked-by: you?
>

Acked-by: Eric Miao <eric.miao@...vell.com>

> Best regards
> Uwe
>
> --
> Pengutronix e.K.                              | Uwe Kleine-König            |
> Industrial Linux Solutions                    | http://www.pengutronix.de/  |
>



-- 
Cheers
- eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/