linux-kernel - Re: [git-pull -tip] x86: include inverse Xmas tree patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 29 Mar 2009 03:58:05 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	"H. Peter Anvin" <hpa@...nel.org>, Sam Ravnborg <sam@...nborg.org>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Jaswinder Singh Rajput <jaswinder@...nel.org>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [git-pull -tip] x86: include inverse Xmas tree patches


* Thomas Gleixner <tglx@...utronix.de> wrote:

> I just run the following on current git:
> 
> # FS=`find -type f`; for F in $FS; do grep -c "#include" $F; done | sort -n | uniq -c
> 
> The top 5 are:
> 
> lib/locking-selftest.c:	108 (justified as this includes all the test cases)
> fs/compat_ioctl.c		 88 (maybe ok as it is the all in one kitchen sink)
> arch/x86/kernel/setup.c:	 76 (completely nuts)

[yep]

> init/main.c:			 62 (needs to be looked at)
> security/selinux/hooks.c	 61 (needs to be looked at, spotted at least 5 which can be removed)
> 
> 1400 files have more than 20 includes. 5375 more than 10.
> 
> I think it's well justified to sit down and work on a tool which 
> helps us analyse and distangle that mess.

yeah.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/