linux-kernel - [PATCH] Fix build error in <linux/irq.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20090329105950.GA21370@linux-mips.org>
Date:	Sun, 29 Mar 2009 12:59:50 +0200
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] Fix build error in <linux/irq.h>

<linux/irq.h> relies on <linux/gfp.h> and <linux/topology.h> having been
included previous.  If not, the errors like below will result.

  CC      arch/mips/mti-malta/malta-int.o
In file included from /home/ralf/src/linux/linux-queue/arch/mips/mti-malta/malta-int.c:25:
/home/ralf/src/linux/linux-queue/include/linux/irq.h: In function ‘init_alloc_desc_masks’:
/home/ralf/src/linux/linux-queue/include/linux/irq.h:444: error: implicit declaration of function ‘cpu_to_node’
/home/ralf/src/linux/linux-queue/include/linux/irq.h:446: error: ‘GFP_ATOMIC’ undeclared (first use in this function)
/home/ralf/src/linux/linux-queue/include/linux/irq.h:446: error: (Each undeclared identifier is reported only once
/home/ralf/src/linux/linux-queue/include/linux/irq.h:446: error: for each function it appears in.)
make[3]: *** [arch/mips/mti-malta/malta-int.o] Error 1
make[2]: *** [arch/mips/mti-malta] Error 2
make[1]: *** [sub-make] Error 2

Fixed by including the two missing headers.

Signed-off-by: Ralf Baechle <ralf@...ux-mips.org>

 include/linux/irq.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index 873e4ac..9c62fbe 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -17,9 +17,11 @@
 #include <linux/cache.h>
 #include <linux/spinlock.h>
 #include <linux/cpumask.h>
+#include <linux/gfp.h>
 #include <linux/irqreturn.h>
 #include <linux/irqnr.h>
 #include <linux/errno.h>
+#include <linux/topology.h>
 
 #include <asm/irq.h>
 #include <asm/ptrace.h>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/