linux-kernel - Re: Regression caused by commit "netfilter: iptables: lock free counters"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090330075619.23677280@nehalam>
Date:	Mon, 30 Mar 2009 07:56:19 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Roman Mindalev <r000n@...0n.net>,
	Eric Dumazet <dada1@...mosbay.com>,
	LKML <linux-kernel@...r.kernel.org>, netfilter@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: Regression caused by commit "netfilter: iptables: lock free
 counters"

On Mon, 30 Mar 2009 14:08:08 +0200
Patrick McHardy <kaber@...sh.net> wrote:

> Roman Mindalev wrote:
> > On Mon, 30 Mar 2009 09:32:51 +0200
> > Eric Dumazet <dada1@...mosbay.com> wrote:
> > 
> >> Could you try following patch ?
> >>
> >> [PATCH] netfilter: use rcu_read_bh() in ipt_do_table()
> >>
> >> Commit 784544739a25c30637397ace5489eeb6e15d7d49
> >> (netfilter: iptables: lock free counters) forgot to disable BH
> >> in arpt_do_table(), ipt_do_table() and  ip6t_do_table()
> >>
> >> Use rcu_read_lock_bh() instead of rcu_read_lock() cures the problem.
> >>
> >> Reported-and-bisected-by: Roman Mindalev <r000n@...0n.net>
> >> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>
> >> ---
> > 
> > 2.6.29-git4 and 2.6.29-git6 both works fine for me with this patch. 
> > Thanks, Eric!
> 
> Thanks indeed Eric :) Dave, please apply.
> 
> Acked-by: Patrick McHardy <kaber@...sh.net>
> 
> 
Acked-by: Stephen Hemminger <shemminger@...tta.com>

The original version had rcu_read_lock_bh() but someone (not sure who)
talked me into removing it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/