linux-kernel - Re: [PATCH] de: drivers/ide/ide-atapi.c needs <linux/scatterlist.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200903302229.31846.bzolnier@gmail.com>
Date:	Mon, 30 Mar 2009 22:29:31 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-ide@...r.kernel.org,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	Dmitri Vorobiev <dmitri.vorobiev@...ial.com>
Subject: Re: [PATCH] de: drivers/ide/ide-atapi.c needs <linux/scatterlist.h>

On Sunday 29 March 2009, Geert Uytterhoeven wrote:
> On m68k:
> | drivers/ide/ide-atapi.c: In function 'ide_io_buffers':
> | drivers/ide/ide-atapi.c:87: error: implicit declaration of function 'sg_page'
> | drivers/ide/ide-atapi.c:87: warning: passing argument 1 of 'PageHighMem' makes pointer from integer without a cast
> | drivers/ide/ide-atapi.c:91: warning: passing argument 1 of 'kmap_atomic' makes pointer from integer without a cast
> | drivers/ide/ide-atapi.c:96: error: implicit declaration of function 'sg_virt'
> | drivers/ide/ide-atapi.c:96: warning: assignment makes pointer from integer without a cast
> | drivers/ide/ide-atapi.c:107: error: implicit declaration of function 'sg_next'
> | drivers/ide/ide-atapi.c:107: warning: assignment makes pointer from integer without a cast
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

thanks, applied

[ Dmitri, sorry but m68k was faster than MIPS this time ;) ]

> ---
> No idea where it got introduced. 2.6.29 was fine.

Hmm... the issue went unnoticed because it was mitigated in linux-next
by ide_pio_bytes() conversion (resulting in ide_io_buffers() removal)...

>  drivers/ide/ide-atapi.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c
> index 6adc5b4..445d157 100644
> --- a/drivers/ide/ide-atapi.c
> +++ b/drivers/ide/ide-atapi.c
> @@ -6,6 +6,8 @@
>  #include <linux/cdrom.h>
>  #include <linux/delay.h>
>  #include <linux/ide.h>
> +#include <linux/scatterlist.h>
> +
>  #include <scsi/scsi.h>
>  
>  #ifdef DEBUG
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/