[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090331090023.e1d30a5a.kamezawa.hiroyu@jp.fujitsu.com>
Date: Tue, 31 Mar 2009 09:00:23 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To: balbir@...ux.vnet.ibm.com
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"kosaki.motohiro@...fujitsu.com" <kosaki.motohiro@...fujitsu.com>,
"nishimura@....nes.nec.co.jp" <nishimura@....nes.nec.co.jp>
Subject: Re: [RFC][PATCH 7/8] memcg soft limit LRU reorder
On Mon, 30 Mar 2009 13:22:46 +0530
Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:
> * KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> [2009-03-27 14:12:25]:
>
> > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> >
> > This patch adds a function to change the LRU order of pages in global LRU
> > under control of memcg's victim of soft limit.
> >
> > FILE and ANON victim is divided and LRU rotation will be done independently.
> > (memcg which only includes FILE cache or ANON can exists.)
> >
> > The routine finds specfied number of pages from memcg's LRU and
> > move it to top of global LRU. They will be the first target of shrink_xxx_list.
>
> This seems to be the core of the patch, but I don't like this very
> much. Moving LRU pages of the mem cgroup seems very subtle, why can't
> we directly use try_to_free_mem_cgroup_pages()?
>
It ignores many things.
Thanks,
-Kame
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists