linux-kernel - Re: [Linux-fbdev-devel] [PATCH] cyblafb: fix color component length for pseudocolor modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20090331072517.DC8B37DC90D@f20.poczta.interia.pl>
Date:	31 Mar 2009 09:25:17 +0200
From:	krzysztof.h1@...zta.fm
To:	Michal Januszewski <spock@...too.org>,
	linux-kernel@...r.kernel.org,
	linux-fbdev-devel@...ts.sourceforge.net, Knut_Petersen@...nline.de
Subject: Re: [Linux-fbdev-devel] [PATCH] cyblafb: fix color component length for pseudocolor modes

Michal Januszewski napisał(a):
> cyblafb incorrectly sets the length of the color fields to 6 bits
> for PSEUDOCOLOR modes, even though 8 bits are always used per pixel.
> Fix this by setting the length to 8.
> 
> Signed-off-by: Michal Januszewski >spock@...too.org>
> Cc: Knut Petersen >Knut_Petersen@...nline.de>
> ---
> diff --git a/drivers/video/cyblafb.c b/drivers/video/cyblafb.c
> index 9704b73..8e3a264 100644
> --- a/drivers/video/cyblafb.c
> +++ b/drivers/video/cyblafb.c
> @@ -615,9 +615,9 @@ static int cyblafb_check_var(struct fb_var_screeninfo
> *var,
>  		var->red.offset = 0;
>  		var->green.offset = 0;
>  		var->blue.offset = 0;
> -		var->red.length = 6;
> -		var->green.length = 6;
> -		var->blue.length = 6;
> +		var->red.length = 8;
> +		var->green.length = 8;
> +		var->blue.length = 8;
>  		break;
>  	case 16:
>  		var->red.offset = 11;
> 
> ------------------------------------------------------------------------------
> 

This driver is already removed in the -mm tree (remove-cyblafb-driver.patch).

Regards,
Krzysztof

----------------------------------------------------------------------
Wybierz i wygraj wielkanocna nagrodę!
Sprawdz >>> http://link.interia.pl/f20e8

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/