linux-kernel - Re: [PATCH] : Code cleanup for fs/inode.c as per checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090331091653.GU28946@ZenIV.linux.org.uk>
Date:	Tue, 31 Mar 2009 10:16:53 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Manish Katiyar <mkatiyar@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, trivial@...nel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] : Code cleanup for fs/inode.c as per checkpatch.pl

On Tue, Mar 31, 2009 at 02:32:37PM +0530, Manish Katiyar wrote:

> -static struct inode * find_inode(struct super_block * sb, struct hlist_head *head, int (*test)(struct inode *, void *), void *data)
> +static struct inode *find_inode(struct super_block *sb, struct hlist_head *head,
> +				int (*test)(struct inode *, void *), void *data)

If you are splitting it, split it all the way, esp. the last line.

> -static struct inode * get_new_inode(struct super_block *sb, struct hlist_head *head, int (*test)(struct inode *, void *), int (*set)(struct inode *, void *), void *data)
> +static struct inode *get_new_inode(struct super_block *sb,
> +				struct hlist_head *head,
> +				int (*test)(struct inode *, void *),
> +				int (*set)(struct inode *, void *), void *data)

Ditto, and that's even more serious case - here 'void *data' part is
really obfuscated.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/