linux-kernel - Re: [PATCH 00/05] tmio_mmc: Minor fixes and cnf/irq changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49D262F5.6020700@mnementh.co.uk>
Date:	Tue, 31 Mar 2009 19:37:41 +0100
From:	Ian Molton <ian@...menth.co.uk>
To:	Magnus Damm <magnus.damm@...il.com>
CC:	Pierre Ossman <drzeus@...eus.cx>, linux-kernel@...r.kernel.org,
	drzeus-wbsd@...eus.cx, akpm@...ux-foundation.org
Subject: Re: [PATCH 00/05] tmio_mmc: Minor fixes and cnf/irq changes

Magnus Damm wrote:

> Ping? Please let me know how you want me to rework the patches. Unless
> they are ok as-is. Any feedback on how to rewrite them would be
> greatly appreciated.

I replied to this earlier. Basically, investigate using the clk API. You 
should also try to work out how your board controls  clock / power to 
the socckets (if it can at all).

Like I said though, IIRC the clk API had shortcommings last time I 
looked which made it impossible to use on MFD devices (its tied to the 
CPU architecture, wheras the MFDs are platform independant. Dmitry did 
some work on this, but I dont recall how far he got.

Let me know if you come up with answers / solutions to these probelms. 
Until then, NAK - lets do it the right way, one time only. Not hack and 
bodge it repeatedly.

Sorry if that seems harsh, but I dont have time to review a hack thats 
going to end up replaced anyway when its done properly.

Best starting point would be to look up Dmitrys work on making the clk 
api CPU agnostic (if that hasnt already been merged). Then tmio-mmc can 
be modified to reqest a clock from its parent device (be that an MFD 
core or a platform device or whatever).

-Ian

-Ian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/