linux-kernel - Re: [patch 18/35 xattr-rework] reiserfs: Clean up xattrs when REISERFS_FS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Mar 2009 14:44:02 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Jeff Mahoney <jeffm@...e.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	ReiserFS Development List <reiserfs-devel@...r.kernel.org>
Subject: Re: [patch 18/35 xattr-rework] reiserfs: Clean up xattrs when
	REISERFS_FS_XATTR is unset

On Mon, Mar 30, 2009 at 02:02:33PM -0400, Jeff Mahoney wrote:
>  The current reiserfs xattr implementation will not clean up old xattr
>  files if files are deleted when REISERFS_FS_XATTR is unset. This results
>  in inaccessible lost files, wasting space.
> 
>  This patch compiles in basic xattr knowledge, such as how to delete them and
>  change ownership for quota tracking. If the file system has never used
>  xattrs, then the operation is quite fast: it returns immediately when
>  it sees there is no .reiserfs_priv directory.

What about just making xattr suppose unconditional?  That's what most
never filesystems do, and it really shouldn't be a whole lot of code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/