linux-kernel - Re: [PATCH] parport: Use the PCI IRQ if offered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090331202316.3b350772@the-village.bc.nu>
Date:	Tue, 31 Mar 2009 20:23:16 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Gabor Kovacs <kgabor@...yai.elte.hu>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parport: Use the PCI IRQ if offered

On Tue, 31 Mar 2009 15:31:56 -0400
Gabor Kovacs <kgabor@...yai.elte.hu> wrote:

> Hi Alan,
> 
> just to confirm, IRQ detection works fine on my Lava parallel card. 
> 
> The instrument driver module that registers an irq handler via 
> parport_register_device gets false events when parport irq is shared e.g. with 
> an ethernet controller. Should irq sharing awareness go to our handler 
> function or parport_irq_handler/parport_generic_irq still needs some 
> additional patch? (Or have I just missed this second patch?)

I suspect it may have to go in the handler functions to avoid the risk of
losing any state reading the registers to see an IRQ is pending. The
ideal case would be to keep it in the common code path however.

I've not looked at that so far as a lot of hardware is just fine without
the checks. I guess try it and see with your actual hardware
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/