lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 31 Mar 2009 08:12:58 +0530 From: Manish Katiyar <mkatiyar@...il.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: trivial@...nel.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] : Convert simple_strtoul to strict_strtoul in fs/inode.c On Tue, Mar 31, 2009 at 5:05 AM, Andrew Morton <akpm@...ux-foundation.org> wrote: > On Mon, 23 Mar 2009 09:02:04 +0530 > Manish Katiyar <mkatiyar@...il.com> wrote: > >> Hi Andrew, >> >> Below patch converts simple_strtoul to strict_strtoul in fs/inode.c >> >> Signed-off-by: Manish Katiyar <mkatiyar@...il.com> >> --- >> fs/inode.c | 8 +++++++- >> 1 files changed, 7 insertions(+), 1 deletions(-) >> >> diff --git a/fs/inode.c b/fs/inode.c >> index e0dad15..ef4a9b1 100644 >> --- a/fs/inode.c >> +++ b/fs/inode.c >> @@ -1447,9 +1447,15 @@ EXPORT_SYMBOL(inode_double_unlock); >> static __initdata unsigned long ihash_entries; >> static int __init set_ihash_entries(char *str) >> { >> + int ret; >> + >> if (!str) >> return 0; >> - ihash_entries = simple_strtoul(str, &str, 0); >> + >> + ret = strict_strtoul(str, 0, &ihash_entries); >> + if (ret < 0 || ihash_entries == 0) >> + return 0; >> + >> return 1; >> } >> __setup("ihash_entries=", set_ihash_entries); > > Again, there is no reason given for making the change. Hi Andrew, It showed up during cleanup of this file via checkpatch.pl. > > Bear in mind that this is not a backward-compatible change! If someone > (stupidly) has > > ihash_entries=42foo > > in their grub.conf then your change would break their kernels. > > it's not a serious problem and we can probably make this change, but > trivial@...nel.org is not a suitable list for discussing and > promulgating the change. I have cced lkml. Thanks - Manish > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists