linux-kernel - Re: [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200904010013.05494.oliver@neukum.org>
Date:	Wed, 1 Apr 2009 00:13:04 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Larry Finger <Larry.Finger@...inger.net>,
	David Miller <davem@...emloft.net>
Cc:	jgarzik@...ox.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe

Am Dienstag 31 März 2009 20:45:49 schrieb Larry Finger:

> @@ -796,7 +799,7 @@ static int kaweth_start_xmit(struct sk_b

> @@ -848,7 +851,7 @@ skip:
>  		net->trans_start = jiffies;
>  	}
>
> -	spin_unlock(&kaweth->device_lock);
> +	spin_unlock_irq(&kaweth->device_lock);

Here you enable interrupts. Are you sure ndo_start_xmit is never
called with interrupts disabled?

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/