linux-kernel - Re: [PATCH -tip] irq: DEBUG_SHIRQ executed on irq setup failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0904010830580.12916@localhost.localdomain>
Date:	Wed, 1 Apr 2009 12:14:25 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Luis Henriques <henrix@...o.pt>
cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -tip] irq: DEBUG_SHIRQ executed on irq setup failure

On Tue, 31 Mar 2009, Luis Henriques wrote:

> When requesting an IRQ, the DEBUG_SHIRQ code executes a fake IRQ just to make
> sure the driver is ready to receive an IRQ immediately.  The problem was that
> this fake IRQ was being executed even if interrupt line failed to be allocated
> by __setup_irq.

Good point !

> Signed-off-by: Luis Henriques <henrix@...o.pt>
> ---
>  kernel/irq/manage.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index a3eb7ba..8e1be16 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -914,7 +914,7 @@ int request_threaded_irq(unsigned int irq, irq_handler_t handler,
>  		kfree(action);
>  
>  #ifdef CONFIG_DEBUG_SHIRQ
> -	if (irqflags & IRQF_SHARED) {
> +	if (retval && (irqflags & IRQF_SHARED)) {

  !retval might actually prevent the situation you described above :)

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/