linux-kernel - Re: [PATCH] Free the temporary vfsmount created in bdev_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1238587928.14550.16.camel@pc1117.cambridge.arm.com>
Date:	Wed, 01 Apr 2009 13:12:08 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Cheng Renquan <crquan@...il.com>
Subject: Re: [PATCH] Free the temporary vfsmount created in
	bdev_cache_init()

On Wed, 2009-04-01 at 12:49 +0100, Al Viro wrote:
> On Wed, Apr 01, 2009 at 12:07:37PM +0100, Catalin Marinas wrote:
> > The vfsmount structure allocated in this function (the bd_mnt local
> > variable) is only used to obtain the blockdev_superblock and there are
> > no other references to it. This structure can be safely freed (and
> > prevent kmemleak from reporting it).
> 
> NAK.  This kind of kludges is simply not worth doing.  Store the
> pointer to vfsmount into a static-in-file variable if you want
> to get kmemleak to STFU.

That's how it used to be until commit c2acf7b9 made bd_mnt a local
variable. Rather than reverting part of this commit, I can add a
kmemleak_ignore() call to shut it up.

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/