linux-kernel - Re: [PATCH 15/17] bio/blk-map: kill unused stuff and un-export internal functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49D371FF.3050202@panasas.com>
Date:	Wed, 01 Apr 2009 16:54:07 +0300
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Tejun Heo <tj@...nel.org>
CC:	axboe@...nel.dk, linux-kernel@...r.kernel.org,
	fujita.tomonori@....ntt.co.jp
Subject: Re: [PATCH 15/17] bio/blk-map: kill unused stuff and un-export internal
 functions

On 04/01/2009 04:44 PM, Tejun Heo wrote:
> Impact: cleanup, removal of unused / undesirable API
> 
> With recent changes, the following functions aren't used anymore.
> 
> * bio_{map|copy}_{user|kern}()
> * blk_rq_append_bio()
> 

This function is used by drivers/scsi/osd/osd_initiator.c
Currently in mainline. Please use allmodconfig to compile
everything.

> The following functions aren't used outside of block layer.
> 
> * bio_add_pc_page()

And also this

> * bio_un{map|copy}_user()
> 
> Kill the first group and unexport the second.  As bio_add_pc_page() is
> used only inside fs/bio.c, it's made static.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>

I've posted propositions on how to fix osd_initiator.c which
involves making blk_map_kern() append to the request, and a new
blk_make_request(bio).

Any suggestions are welcome

Thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/