linux-kernel - Re: [patch 2/3] uml: fix link error from prefixing of i386 syscalls with ptregs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Apr 2009 00:03:49 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	user-mode-linux-devel@...ts.sourceforge.net, jdike@...toit.com,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 2/3] uml: fix link error from prefixing of i386
	syscalls with ptregs_

On Mon, Mar 30, 2009 at 08:47:12PM +0200, Miklos Szeredi wrote:
>From: Miklos Szeredi <mszeredi@...e.cz>
>
>Fix the following link error:
>
>arch/um/sys-i386/built-in.o: In function `sys_call_table':
>(.rodata+0x11c): undefined reference to `ptregs_fork'
>arch/um/sys-i386/built-in.o: In function `sys_call_table':
>(.rodata+0x140): undefined reference to `ptregs_execve'
>arch/um/sys-i386/built-in.o: In function `sys_call_table':
>(.rodata+0x2cc): undefined reference to `ptregs_iopl'
>arch/um/sys-i386/built-in.o: In function `sys_call_table':
>(.rodata+0x2d8): undefined reference to `ptregs_vm86old'
>arch/um/sys-i386/built-in.o: In function `sys_call_table':
>(.rodata+0x2f0): undefined reference to `ptregs_sigreturn'
>arch/um/sys-i386/built-in.o: In function `sys_call_table':
>(.rodata+0x2f4): undefined reference to `ptregs_clone'
>arch/um/sys-i386/built-in.o: In function `sys_call_table':
>(.rodata+0x3ac): undefined reference to `ptregs_vm86'
>arch/um/sys-i386/built-in.o: In function `sys_call_table':
>(.rodata+0x3c8): undefined reference to `ptregs_rt_sigreturn'
>arch/um/sys-i386/built-in.o: In function `sys_call_table':
>(.rodata+0x3fc): undefined reference to `ptregs_sigaltstack'
>arch/um/sys-i386/built-in.o: In function `sys_call_table':
>(.rodata+0x40c): undefined reference to `ptregs_vfork'
>
>This was introduced by commit 253f29a4, "x86: pass in pt_regs pointer
>for syscalls that need it"
>
>Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>

Looks good.

Reviewed-by: WANG Cong <xiyou.wangcong@...il.com>


>---
> arch/um/sys-i386/sys_call_table.S |   11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>Index: linux-2.6/arch/um/sys-i386/sys_call_table.S
>===================================================================
>--- linux-2.6.orig/arch/um/sys-i386/sys_call_table.S	2009-03-27 10:57:38.000000000 +0100
>+++ linux-2.6/arch/um/sys-i386/sys_call_table.S	2009-03-30 19:53:14.000000000 +0200
>@@ -9,6 +9,17 @@
> 
> #define old_mmap old_mmap_i386
> 
>+#define ptregs_fork sys_fork
>+#define ptregs_execve sys_execve
>+#define ptregs_iopl sys_iopl
>+#define ptregs_vm86old sys_vm86old
>+#define ptregs_sigreturn sys_sigreturn
>+#define ptregs_clone sys_clone
>+#define ptregs_vm86 sys_vm86
>+#define ptregs_rt_sigreturn sys_rt_sigreturn
>+#define ptregs_sigaltstack sys_sigaltstack
>+#define ptregs_vfork sys_vfork
>+
> .section .rodata,"a"
> 
> #include "../../x86/kernel/syscall_table_32.S"
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
Do what you love, f**k the rest! F**k the regulations!
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/