linux-kernel - Re: [PATCH] writeback: guard against jiffies wraparound on inode->dirtied

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090331180730.049d42e7.akpm@linux-foundation.org>
Date:	Tue, 31 Mar 2009 18:07:30 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jeff Layton <jlayton@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] writeback: guard against jiffies wraparound on
 inode->dirtied_when checks (try #2)

On Tue, 31 Mar 2009 20:50:18 -0400 Jeff Layton <jlayton@...hat.com> wrote:

> On Tue, 31 Mar 2009 17:20:31 -0700
> Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> > On Tue, 31 Mar 2009 20:03:59 -0400
> > Jeff Layton <jlayton@...hat.com> wrote:
> > 
> > > +		 * It's not sufficient to just do a time_after() check on
> > > +		 * dirtied_when. That assumes that dirtied_when will always
> > > +		 * change within a period of jiffies that encompasses half the
> > > +		 * machine word size (2^31 jiffies on 32-bit arch). That's not
> > > +		 * necessarily the case if an inode is being constantly
> > > +		 * redirtied. Since dirtied_when can never be in the future,
> > > +		 * we can assume that if it appears to be so then it is
> > > +		 * actually in the distant past.
> > 
> > so this really is a 32-bit-only thing.
> > 
> > I guess that isn't worth optimising for though.
> > 
> 
> Yeah, it's pretty much impossible to hit this on a 64-bit machine.
> 
> > otoh, given that all three comparisons are the same:
> > 
> > +			time_after(inode->dirtied_when, *older_than_this) &&
> > +			time_before_eq(inode->dirtied_when, jiffies))
> > 
> > (although one is inverted (i think?)), it might end up nicer if this was all done
> > in a little helper function?
> > 
> > That way we only need to comment what's going on at a single site, and
> > we could omit the additional test if !CONFIG_64BIT.
> 
> Ok, that seems reasonable.
> 
> At one point I had a macro similar to time_in_range(), but dropped it
> primarily because time_after_but_before_eq() wasn't easy on the eyes.
> Thoughts on better names?

I was thinking

	bool inode_dirtied_after(...);

and just leave the innards using time_after() and time_before_eq()?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/