linux-kernel - Re: [PATCH -tip 0/4 V3] tracing: kprobe-based event tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090401174720.GA19225@elte.hu>
Date:	Wed, 1 Apr 2009 19:47:20 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Masami Hiramatsu <mhiramat@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	systemtap-ml <systemtap@...rces.redhat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jim Keniston <jkenisto@...ibm.com>
Subject: Re: [PATCH -tip 0/4 V3] tracing: kprobe-based event tracer


* Masami Hiramatsu <mhiramat@...hat.com> wrote:

> >> I agreed. Fortunately, Jim Keniston and I wrote an x86 
> >> instruction decoder :-) which has been made originally for 
> >> uprobe andd kprobes jump-optimizer.
> >>
> >> https://www.redhat.com/archives/utrace-devel/2009-March/msg00031.html
> > 
> > looks cool. Needs to be put somewhere in arch/x86/lib/, provided 
> > as a generic facility, with a Kconfig variable that says that 
> > the architecture supports it and then the kprobes-tracer could 
> > make immediate use of it, right?
> 
> Yeah, I'd rather add a safety checker in kprobes-x86 itself, 
> because sometimes it has to fixup instructions modified by 
> previous kprobes.

Oh, certainly! I didnt know how much you wanted to check things on 
the kprobes side but by all means please add it there too, it will 
be for the better.

A clear and actionable debug message to the syslog is important for 
the case where the decoder rejects an action. This is especially 
important for the kprobes side - we dont want silent breakage of 
tools.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/