linux-kernel - Re: + signals-tracehook_notify_jctl-change.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 1 Apr 2009 20:22:24 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org, mm-commits@...r.kernel.org,
	roland@...hat.com
Subject: Re: + signals-tracehook_notify_jctl-change.patch added to -mm tree

On 04/01, Ingo Molnar wrote:
>
> * akpm@...ux-foundation.org <akpm@...ux-foundation.org> wrote:
>
> > Subject: signals: tracehook_notify_jctl change
> > From: Roland McGrath <roland@...hat.com>
> >
> > This changes tracehook_notify_jctl() so it's called with the siglock held,
> > and changes its argument and return value definition.  These clean-ups
> > make it a better fit for what new tracing hooks need to check.
> >
> > Tracing needs the siglock here, held from the time TASK_STOPPED was set,
> > to avoid potential SIGCONT races if it wants to allow any blocking in its
> > tracing hooks.
> >
> > This also folds the finish_stop() function into its caller
> > do_signal_stop().  The function is short, called only once and only
> > unconditionally.  It aids readability to fold it in.
> >
> > Signed-off-by: Roland McGrath <roland@...hat.com>
> > Cc: Oleg Nesterov <oleg@...hat.com>
> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>
> Roland: as i have asked you before, i'd like to see explicit Ack's
> from Oleg for all ptrace patches you submit.

I agree with Roland's patch.

In my opinion, we can simplify utrace_report_jctl() a bit, but this
requires more changes in kernel/signal.c, we can do this later.

Acked-by: Oleg Nesterov <oleg@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/