linux-kernel - Re: [patch 4/6] x86: irqinit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090401185634.GB28212@localhost>
Date:	Wed, 1 Apr 2009 22:56:34 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Ingo Molnar <mingo@...e.hu>, hpa@...or.com, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, xemul@...nvz.org,
	yhlu.kernel@...il.com
Subject: Re: [patch 4/6] x86: irqinit - merge native_init_IRQ

[Cyrill Gorcunov - Wed, Apr 01, 2009 at 09:22:08PM +0400]
| Ingo,
| 
| here is what I meant. The x86_quirk_pre_intr_init
| and x86_quirk_intr_init do all we need. The only
| paid off -- is that on x86-64 the functions
| will check for x86_quirks->arch_intr_init and
| x86_quirks->arch_pre_intr_init which are always
| NULL for x86-64 (at least for now). If that is
| acceptable -- then apply the patch below for
| testing please. Othrewise we could eliminate
| useless check by #ifdef (which would not be
| that much differ from what I've posted initially
| in patch series :)
| 
|         Cyrill
| ---
| 
| x86: irqinit - merge native_init_IRQ
| 
| For this purpose on X86-64 init_ISA_irqs is called
| indirectly via x86_quirk_pre_intr_init (ie the same
| way as X86-32 do).
| 
| Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
| ---
|  arch/x86/kernel/irqinit_32.c |    4 +++-
|  arch/x86/kernel/irqinit_64.c |   22 +++++++++++++++++++++-
|  arch/x86/kernel/setup.c      |    2 +-
|  3 files changed, 25 insertions(+), 3 deletions(-)
| 
...

Ingo,

here are the reasons I found to vote for _this_ implementation
(ie using x86_quirk_intr_init and x86_quirk_pre_intr_init
 for both x86-32 and x86-64 platforms instead of direct function
 pointers)

1) Both are called on x86-32 as a former.
2) For x86-32 among the init_ISA_irqs call
   the quirk itself is needed (VISWS code)

        Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/