linux-kernel - Re: [RFC PATCH 09/17] net: Add vbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49D4A4F9.6090007@novell.com>
Date:	Thu, 02 Apr 2009 07:43:53 -0400
From:	Gregory Haskins <ghaskins@...ell.com>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	linux-kernel@...r.kernel.org, agraf@...e.de, pmullaney@...ell.com,
	pmorreale@...ell.com, anthony@...emonkey.ws, rusty@...tcorp.com.au,
	netdev@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [RFC PATCH 09/17] net: Add vbus_enet driver

Stephen Hemminger wrote:
> On Tue, 31 Mar 2009 14:43:34 -0400
> Gregory Haskins <ghaskins@...ell.com> wrote:
>   
>> +struct vbus_enet_priv {
>> +	spinlock_t                 lock;
>> +	struct net_device         *dev;
>> +	struct vbus_device_proxy  *vdev;
>> +	struct napi_struct         napi;
>> +	struct net_device_stats    stats;
>>     
>
> Not needed any more, stats are available in net_device
>
>   

Thanks for the review, Stephen!

I will apply all of your recommended fixes for the next release.

-Greg


Download attachment "signature.asc" of type "application/pgp-signature" (258 bytes)