linux-kernel - Re: [PATCH] tracing: mark get_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Apr 2009 14:26:13 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	Steven Rostedt <srostedt@...hat.com>, Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: mark get_parent_ip() notrace

On Thu, Apr 02, 2009 at 02:18:25PM +0800, Lai Jiangshan wrote:
> 
> Impact: remove redundancy tracing log
> 
> When tracer is "function" or "function_graph", too much
> "get_parent_ip" are recorded in ring_buffer.


Thanks, indeed this get_parent_ip was a bit harrassing
in the traces, though I still don't understand why it is
called so often.

Anyway, tracing it seems to me not useful.

Acked-by: Frederic Weisbecker <fweisbec@...il.com>


 
> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
> ---
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 706517c..a0ec10c 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -4860,7 +4860,7 @@ void scheduler_tick(void)
>  #endif
>  }
>  
> -unsigned long get_parent_ip(unsigned long addr)
> +notrace unsigned long get_parent_ip(unsigned long addr)
>  {
>  	if (in_lock_functions(addr)) {
>  		addr = CALLER_ADDR2;
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/