linux-kernel - Re: [v0 PATCH 2/5] EDAC: Add CPC925 driver source file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200904021440.17366.arnd@arndb.de>
Date:	Thu, 2 Apr 2009 14:40:16 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Harry Ciao <qingtao.cao@...driver.com>
Cc:	norsk5@...oo.com, linux-kernel@...r.kernel.org,
	bluesmoke-devel@...ts.sourceforge.net, linuxppc-dev@...abs.org
Subject: Re: [v0 PATCH 2/5] EDAC: Add CPC925 driver source file

On Thursday 02 April 2009, Harry Ciao wrote:
> Introduce IBM CPC925 EDAC driver source file, which makes use of error
> detections on the IBM CPC925 Bridge and Memory Controller.
> 
> Signed-off-by: Harry Ciao <qingtao.cao@...driver.com>

On a very brief review, the driver looks good to me, but please
post the full series to the linuxppc-dev@...abs.org mailing list
as well, because that is likely to have more people that will
comment on it.

The first three patches of your series should be merged into
a single one, because none of them has any signficance by itself.
You may also consider moving the contents of the header file
into the main driver, because it does not actually act as an
interface.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/