linux-kernel - Re: [PATCH 4/5] bfa: Brocade BFA FC SCSI driver (makefile)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Apr 2009 08:36:01 -0500
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Krishna Gudipati <kgudipat@...cade.com>
Cc:	huangj@...cade.com, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org, nkattang@...cade.com,
	rvadivel@...cade.com, vravindr@...cade.com
Subject: Re: [PATCH 4/5] bfa: Brocade BFA FC SCSI driver (makefile)

On Wed, 2009-04-01 at 20:35 -0700, Krishna Gudipati wrote:
> From: Krishna Chaitanya Gudipati <kgudipat@...cade.com>
> 
> This patch contains Makefile and Kconfig file for scsi and bfa.Fixed
> the code review comments from previous submission.
> 
> Signed-off-by: Krishna Chaitanya Gudipati <kgudipat@...cade.com>
> ---
>  Kconfig      |    9 +++++++++
>  Makefile     |    1 +
>  bfa/Makefile |   27 +++++++++++++++++++++++++++
>  3 files changed, 37 insertions(+)
> 
> diff -urpN orig/drivers/scsi/Kconfig patch/drivers/scsi/Kconfig
> --- orig/drivers/scsi/Kconfig	2009-04-01 20:08:49.271161000 -0700
> +++ patch/drivers/scsi/Kconfig	2009-04-01 20:08:44.003822000 -0700
> @@ -1797,6 +1797,15 @@ config SCSI_SRP
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called libsrp.
>  
> +config SCSI_BFA_FC
> +	tristate "Brocade BFA Fibre Channel Support"
> +	depends on PCI && SCSI
> +	help
> +	  This bfa driver supports all Brocade PCIe Fibre Channel host adapters.
> +
> +	  To compile this driver as a module, choose M here. The module will
> +	  be called bfa.
> +

You're still not using the FC transport class to export common sysfs FC
information or to help make your driver smaller.  I thought you were
going to fix this after this was noted in your first submission to
linux-scsi on 24 September?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/