linux-kernel - Re: [Bug 487894] New: sky2 0000:06:00.0: DMA-API: device driver frees DMA memory with different size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090402230346B.fujita.tomonori@lab.ntt.co.jp>
Date:	Thu, 2 Apr 2009 23:03:58 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	joerg.roedel@....com
Cc:	fujita.tomonori@....ntt.co.jp, shemminger@...tta.com,
	davej@...hat.com, tglx@...uxtronix.de, mingo@...hat.com,
	hpa@...or.com, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [Bug 487894] New: sky2 0000:06:00.0: DMA-API: device driver
	frees DMA memory with different size

On Thu, 2 Apr 2009 13:18:39 +0200
Joerg Roedel <joerg.roedel@....com> wrote:

> On Thu, Apr 02, 2009 at 08:06:26PM +0900, FUJITA Tomonori wrote:
> > On Thu, 2 Apr 2009 12:54:15 +0200
> > Joerg Roedel <joerg.roedel@....com> wrote:
> > 
> > > On Wed, Apr 01, 2009 at 11:02:45AM -0700, Stephen Hemminger wrote:
> > > > 
> > > > The sky2 driver uses pci_unmap_len and pci_unmap_len_set which on 32 bit
> > > > platforms are meaningless so they are stubbed out. 
> > > > Basically, DMA-API checks are wrong/bogus to enforce on 32bit x86 as is.
> > > 
> > > As far as I know the VT-d driver is available on 32 bit x86 too. So this should
> > > not always be a nop.
> > 
> > VT-d is available on only x86_64.
> 
> At least there was a patch to enable it on 32 bit too. See
> 
> https://lists.linux-foundation.org/pipermail/iommu/2009-February/001080.html
> 
> It seems not to be upstream yet.

It's not in upstream.


Anyway, about the original problem, I think that the best fix is not
to stub out the dma API; using the dma API properly is always a good
thing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/