linux-kernel - Re: [PATCH 22/43] CacheFiles: Add a hook to write a single page of data to an inode [ver #46]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090402165505.GA21859@infradead.org>
Date:	Thu, 2 Apr 2009 12:55:05 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Nick Piggin <nickpiggin@...oo.com.au>
Cc:	Christoph Hellwig <hch@...radead.org>,
	David Howells <dhowells@...hat.com>, viro@...iv.linux.org.uk,
	nfsv4@...ux-nfs.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 22/43] CacheFiles: Add a hook to write a single page of
	data to an inode [ver #46]

On Fri, Apr 03, 2009 at 03:47:20AM +1100, Nick Piggin wrote:
> Well they now are quite well filesystem defined. We no longer take
> the page lock before calling them. Not saying it's perfect, but if
> the backing fs is just using a known subset of ones that work
> (like loop does).

The page lock doesn't matter.  What matters is locks protecting the
io.  Like the XFS iolock or cluster locks in the cluster filesystems,
and you will get silent data corruption that way.

I would have sworn loop was fixed by now as gfs people were seeing
these issues and submitting patches, but it looks like we never sorted
this out upstream.

> Probably yes. But it seems like it should have more discussion IMO
> (unless it has already been had and I missed it).

This came up plenty of times.

> I don't think "write_one_page" sounds like a particularly good new
> API addition.

I also thing it's not a nice one.  I still haven't seen a really good
explanation of why it can't just use plain ->write

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/