linux-kernel - Re: [patch 14/18] x86, ds: use single debug store cpu configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090402192942.GE2455@elte.hu>
Date:	Thu, 2 Apr 2009 21:29:42 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	markus.t.metzger@...el.com
Cc:	tglx@...utronix.de, hpa@...or.com, markus.t.metzger@...il.com,
	roland@...hat.com, eranian@...glemail.com, oleg@...hat.com,
	juan.villacis@...el.com, ak@...ux.jf.intel.com,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 14/18] x86, ds: use single debug store cpu configuration


* markus.t.metzger@...el.com <markus.t.metzger@...el.com> wrote:

> Use a single configuration for all cpus.
> 

> @@ -1291,11 +1290,15 @@ ds_configure(const struct ds_configurati
>  	printk("bts/pebs record: %u/%u bytes\n",
>  	       ds_cfg.sizeof_rec[ds_bts], ds_cfg.sizeof_rec[ds_pebs]);
>  
> -	WARN_ON_ONCE(MAX_SIZEOF_DS < (12 * ds_cfg.sizeof_ptr_field));
> +	WARN_ON(MAX_SIZEOF_DS < (12 * ds_cfg.sizeof_ptr_field));

Why this change?

Firstly, it was not declared in the changelog which is a no-no. 

Secondly, this is a bad change: we are more than content to have a 
single such warning bootup - not dozens of it (on some large 
system).

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/