linux-kernel - Re: [PATCH] ide: Fix host drivers that need IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200904022045.54971.bzolnier@gmail.com>
Date:	Thu, 2 Apr 2009 20:45:49 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-ide@...r.kernel.org,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ide: Fix host drivers that need IRQF_SHARED

On Tuesday 31 March 2009, Geert Uytterhoeven wrote:
> commit 255115fb35f80735c21a1cbe9809e9795a3af26e ("ide: allow host drivers to
> specify IRQ flags") added irq_flags fields to struct ide_port_info and struct
> ide_host.  Drivers can now set ide_port_info.irq_flags = IRQF_SHARED, while
> init_irq() passes ide_host.irq_flags to request_irq().
> 
> Unfortunately ide_host.irq_flags is never set, causing (on ARAnyM):
> 
> | Uniform Multi-Platform E-IDE driver
> | ide: Falcon IDE controller
> | Probing IDE interface ide0...
> | hda: Sarge m68k, ATA DISK drive
> | init_irq: sa = 0
> | ide0: disabled, unable to get IRQ 15
> | ide0: failed to initialize IDE interface
> | ide0: disabling port
> 
> Solve this by copying ide_port_info.irq_flags to ide_host.irq_flags in
> ide_host_alloc().
> 
> This bug probably affects the following IDE host drivers:
>   - buddha
>   - delkin_cb
>   - falconide
>   - gayle
>   - ide-cs
>   - macide
>   - q40ide
>   - scc_pata
>   - sgiioc4
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

applied
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/