linux-kernel - Re: [PATCH 1/2] SMI Detector: a simple module for detecting System Management Interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090402151621.171a95c9@torg>
Date:	Thu, 2 Apr 2009 15:16:21 -0500
From:	Clark Williams <williams@...hat.com>
To:	Frédéric Weisbecker <fweisbec@...il.com>
Cc:	Jon Masters <jcm@...masters.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Jon Masters <jcm@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Steven Rostedt <rostedt@...dmis.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Luis Claudio R. Goncalves" <lgoncalv@...hat.com>
Subject: Re: [PATCH 1/2] SMI Detector: a simple module for detecting System
  Management Interrupts

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu, 2 Apr 2009 21:05:26 +0200
Frédéric Weisbecker <fweisbec@...il.com> wrote:


> > +#if 1
> > +       val = simple_strtol(buffer, NULL, 10);
> > +#else
> > +       if (strict_strtol(buffer, 10, &val))
> > +               return -EINVAL;
> > +#endif
> 
> 
> 
> So I guess the #else statement can disappear? :-)
> 
> 

Ugh, don't blame Jon for that. I was trying to get rid of some
checkpatch warnings and was experimenting with strict vs. simple
strtol. 

I'll clean that up in the next iteration. Or Jon can and will then
abuse me :)

Clark

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEARECAAYFAknVHRoACgkQHyuj/+TTEp0ndwCfe4ZeEsdflVY3udv9ukk7wKVQ
OycAn1Nl1OQr7nPUxPp3rln5SYVE4Bcn
=kZRN
-----END PGP SIGNATURE-----